Remove old Windows 7 support code #2817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Errf, I still use windows-rs on Windows 7, this change is going to cause me issues. Starting with Rust 1.76, there is now a dedicated for windows7, called |
|
Just turn it into a nop? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update finally drops Windows 7 support from the
windows-corecrate as I did for C++/WinRT some months ago. Much like the Rust compiler, this "support" was never actually tested as we don't have test infrastructure for Windows 7. As a consequence, some Windows 8 only dependencies had crept in a long time ago.