New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harden generic type parameter binding #2791

Merged

kennykerr merged 2 commits into master from into-param-type

Jan 15, 2024

Collaborator

kennykerr commented Jan 12, 2024

Some minor housekeeping around generic type parameter binding.

The internal abi helper wasn't needed as transmute_copy works just fine.
The into_param trait function is rightly unsafe.
Added some more test coverage to cover all paths.

kennykerr added 2 commits

January 12, 2024 14:01


          into-param-type

f9ae8a9


          unnecessary unsafe block

Collaborator Author

kennykerr commented Jan 13, 2024

Weird how 1.62 will warn about unnecessary unsafe blocks but nightly doesn't pick it up.

https://github.com/microsoft/windows-rs/actions/runs/7506895207/job/20439317989

kennykerr merged commit 0564375 into master

65 checks passed

kennykerr deleted the into-param-type branch

January 15, 2024 02:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet