Truncate standalone test files instead of removing #2778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes that does seem to fix the endless loop. :) |
|
I can't repro that nightly warning, but I fixed it here: b5e5000 If you merge master you should be good to go. |
kennykerr
previously approved these changes
Jan 7, 2024
|
Thanks for testing! I've added a comment to explain why we're doing this. |
kennykerr
reviewed
Jan 8, 2024
Co-Authored-By: Kenny Kerr <kenny@kennykerr.ca>
riverar
previously approved these changes
Jan 8, 2024
kennykerr
reviewed
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix #2777 by truncating the test files instead of removing them. This may help avoid an endless loop in rust-analyzer (see also rust-lang/rust-analyzer#16250).
cc @RalfJung would you be able to test if this helps?