Implement std::error::Error for new metadata Error type
#2528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the introduction of [a new `Error` type in the metadata] it is impossible to bubble up results from `File::new()` into `anyhow` using the `?` operator because this type doesn't implement `Error`, while it can be trivially implemented with all functions left at their default implementation. [a new `Error` type in the metadata]: https://github.com/microsoft/windows-rs/pull/2510/files#r1203845316
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the introduction of a new
Errortype in the metadata it is impossible to bubble up results fromFile::new()intoanyhowusing the?operator because this type doesn't implementError, while it can be trivially implemented with all functions left at their default implementation.Fixes: https://github.com/microsoft/windows-rs/pull/2510/files#r1203845316