Validate baseline for lib files #2132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm for some reason, my intentional break of the baseline (479946e) isn't breaking the build. Oh... 😜 https://github.com/microsoft/windows-rs/actions/runs/3377764644/jobs/5607099985#step:3:23 |
|
Yay, build now fails if target lib baseline has changed. |
kennykerr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the target libs are binary files and cannot be easily compared, this update stores a text baseline so that we can easily tell if any lib changes have snuck in unawares. The CI build should also validate that no such changes have occurred and fail the build if that's the case.
This just validates the function signatures and associated library names. Ideally, the build can also rebuild all the libs and validate that the lib binaries are identical but that will require more yml trickery.