Use the msvc target crates for gnullvm targets #1961
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The import libraries in crates/target/*_gnullvm only differ from the ones in crates/target/*_msvc the following ways: - their file name - they don't contain the second "/" linker member with symbol names in lexical order. - the members are not in the same order. That's about it. Both binutils ld and lld will happily find $lib.lib import libraries as well as lib$lib.a ones, so the file name doesn't matter. The other differences also don't have any practical consequence. This means it is not necessary to add extra crates for the purpose of the gnullvm target, especially when e.g. `cargo vendor` will want to vendor them all, and we can reuse the msvc ones, although their name could cause some confusion.
|
Hey @glandium, we explicitly asked for the separate crate #1846 (review).
But we're open minded. Is there a problem with what we're doing today that we should consider? Please create an issue to discuss! See also: |
|
I will file an issue shortly for various changes I have pending wrt the import libraries. I wanted to get this one out of the way first, before the extra crates end up published. |
|
Thanks for the contribution! Sorry I've been gone for a few weeks. I'll close this PR for now but let's continue the discussion #1964 as there appears to be a lot of open questions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The import libraries in crates/target/_gnullvm only differ from the
ones in crates/target/_msvc the following ways:
lexical order.
That's about it. Both binutils ld and lld will happily find $lib.lib
import libraries as well as lib$lib.a ones, so the file name doesn't
matter. The other differences also don't have any practical consequence.
This means it is not necessary to add extra crates for the purpose of
the gnullvm target, especially when e.g.
cargo vendorwill want tovendor them all, and we can reuse the msvc ones, although their name
could cause some confusion.
Fixes #1964