-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SetWindowLongPtrW
documentation expects isize
, compilation fails expecting i32
(i686-pc-windows-msvc)
#3304
Labels
question
Further information is requested
Comments
kennykerr
added
question
Further information is requested
and removed
bug
Something isn't working
labels
Sep 30, 2024
That's because windows-rs/crates/libs/windows/src/includes/Win32/UI/WindowsAndMessaging/WindowLong.rs Lines 1 to 8 in 622d8bd
|
LGUG2Z
added a commit
to LGUG2Z/komorebi
that referenced
this issue
Oct 1, 2024
This commit ensures that komorebi will compile when targeting 32-bit architectures, namely `stable-i686-pc-windows-msvc`. Thanks to @kennykerr for pointing out that Get/SetWindowLongPtrA/W calls don't actually exist on 32-bit builds of Windows and are aliased instead to Get/SetWindowLongA/W which take i32 args instead of isize args: microsoft/windows-rs#3304
LGUG2Z
added a commit
to LGUG2Z/komorebi
that referenced
this issue
Oct 1, 2024
This commit ensures that komorebi will compile when targeting 32-bit architectures, namely `stable-i686-pc-windows-msvc`. Thanks to @kennykerr for pointing out that Get/SetWindowLongPtrA/W calls don't actually exist on 32-bit builds of Windows and are aliased instead to Get/SetWindowLongA/W which take i32 args instead of isize args: microsoft/windows-rs#3304
LGUG2Z
added a commit
to LGUG2Z/komorebi
that referenced
this issue
Oct 2, 2024
This commit ensures that komorebi will compile when targeting 32-bit architectures, namely `stable-i686-pc-windows-msvc`. Thanks to @kennykerr for pointing out that Get/SetWindowLongPtrA/W calls don't actually exist on 32-bit builds of Windows and are aliased instead to Get/SetWindowLongA/W which take i32 args instead of isize args: microsoft/windows-rs#3304
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
The docs state that
SetWindowLongPtrW
's final argument should take anisize
: https://microsoft.github.io/windows-docs-rs/doc/windows/Win32/UI/WindowsAndMessaging/fn.SetWindowLongPtrW.htmlWhen compiling against
stable-i686-pc-windows-msvc
, a compilation error suggests that ani32
is expected:Compilation against
stable-x86_64-pc-windows-msvc
succeeds as expected.Crate manifest
Crate code
The text was updated successfully, but these errors were encountered: