Simpler namespace type collection (#2901)

microsoft · Feb 28, 2024 · 5d06199 · 5d06199
1 parent a2da63c
commit 5d06199
Showing 1 changed file with 28 additions and 18 deletions.
diff --git a/crates/libs/bindgen/src/rust/mod.rs b/crates/libs/bindgen/src/rust/mod.rs
@@ -178,32 +178,35 @@ fn namespace(writer: &Writer, tree: &Tree) -> String {
                     continue;
                 }
                 let name = type_name.name;
-                let kind = def.kind();
-                match kind {
+                let mut kind = def.kind();
+
+                let tokens = match kind {
                     metadata::TypeKind::Class => {
                         if def.flags().contains(metadata::TypeAttributes::WindowsRuntime) {
-                            types.entry(kind).or_default().insert(name, classes::writer(writer, def));
+                            classes::writer(writer, def)
+                        } else {
+                            quote! {}
                         }
                     }
-                    metadata::TypeKind::Interface => types.entry(kind).or_default().entry(name).or_default().combine(&interfaces::writer(writer, def)),
-                    metadata::TypeKind::Enum => types.entry(kind).or_default().entry(name).or_default().combine(&enums::writer(writer, def)),
+                    metadata::TypeKind::Interface => interfaces::writer(writer, def),
+                    metadata::TypeKind::Enum => enums::writer(writer, def),
                     metadata::TypeKind::Struct => {
-                        if def.fields().next().is_none() {
-                            if let Some(guid) = metadata::type_def_guid(def) {
-                                let ident = to_ident(name);
-                                let value = writer.guid(&guid);
-                                let guid = writer.type_name(&metadata::Type::GUID);
-                                let constant = quote! {
-                                    pub const #ident: #guid = #value;
-                                };
-                                types.entry(metadata::TypeKind::Class).or_default().entry(name).or_default().combine(&constant);
-                                continue;
+                        if let Some(guid) = clsid(def) {
+                            kind = metadata::TypeKind::Class;
+                            let ident = to_ident(name);
+                            let value = writer.guid(&guid);
+                            let guid = writer.type_name(&metadata::Type::GUID);
+                            quote! {
+                                pub const #ident: #guid = #value;
                             }
+                        } else {
+                            structs::writer(writer, def)
                         }
-                        types.entry(kind).or_default().entry(name).or_default().combine(&structs::writer(writer, def));
                     }
-                    metadata::TypeKind::Delegate => types.entry(kind).or_default().entry(name).or_default().combine(&delegates::writer(writer, def)),
-                }
+                    metadata::TypeKind::Delegate => delegates::writer(writer, def),
+                };
+
+                types.entry(kind).or_default().entry(name).or_default().combine(&tokens);
             }
             metadata::Item::Fn(def, namespace) => {
                 let name = def.name();
@@ -233,6 +236,13 @@ fn namespace(writer: &Writer, tree: &Tree) -> String {
     tokens.into_string()
 }
 
+fn clsid(def: metadata::TypeDef) -> Option<metadata::Guid> {
+    if def.fields().next().is_none() {
+        return metadata::type_def_guid(def);
+    }
+    None
+}
+
 fn namespace_impl(writer: &Writer, tree: &Tree) -> String {
     let writer = &mut writer.clone();
     writer.namespace = tree.namespace;