Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional AlternateSuccessCodes #758

Merged
merged 2 commits into from
Dec 9, 2021
Merged

Conversation

dqtsth
Copy link
Contributor

@dqtsth dqtsth commented Nov 25, 2021

Hi i make search on google for "IEnum next site:https://docs.microsoft.com/en-us/windows/win32/" and found more methods with other return codes. Some return S_FALSE also IDirectorySearch and IADsPropertyList I find return other S_ codes like here https://docs.microsoft.com/en-us/windows/win32/adsi/generic-adsi-error-codes

@ghost
Copy link

ghost commented Nov 25, 2021

CLA assistant check
All CLA requirements met.

@mikebattista
Copy link
Collaborator

Thanks for providing the list.

Per #559 (comment) we will be replacing the AlternateSuccessCodes attribute with just DllImport.PreserveSig. Once we do that, we'll update the design here to include the list.

@kennykerr
Copy link
Contributor

This is blocking customers: microsoft/windows-rs#1371 (comment)

Per #559 (comment) we will be replacing the AlternateSuccessCodes attribute with just DllImport.PreserveSig. Once we do that, we'll update the design here to include the list.

Can we take this PR in the short term or are we planning on completing the replacement some time soon?

@mikebattista
Copy link
Collaborator

I'll merge this in the short term.

@mikebattista mikebattista merged commit dd8c766 into microsoft:master Dec 9, 2021
@mikebattista
Copy link
Collaborator

Merged. @sotteson1 will push a new metadata package to NuGet once the CI build finishes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants