Create msbuild ProjectionMetadataWinmd item in package import #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of setting the `MicrosoftWindowsSdkWin32MetadataBasePath` msbuild property, which is a scalar and only allows one assignment, we now add to an msbuild item list so that projections (e.g. CsWin32) may consume many such metadata winmds in one build.
Merged
2 tasks
sotteson1
approved these changes
Sep 1, 2021
|
@sotteson1 The pipeline failed with a package push failure. Why are PR builds pushing packages anyway? And if it's intentional, can you look into the failure? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of setting the
MicrosoftWindowsSdkWin32MetadataBasePathmsbuild property, which is a scalar and only allows one assignment, we now add to an msbuild item list so that projections (e.g. CsWin32) may consume many such metadata winmds in one build.microsoft/CsWin32#386 will consume this change.