Annotate missing ComOutPtr in CompositionSwapchain and `DirectCom…
#1970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…position` `dcomp.h` and `Presentation.h` are missing some `_COM_Outptr_` annotations, turning these functions in `windows-rs` to take a meaningless `*mut *mut c_void`. With this annotation the functions return a generic `T: Interface` _and_ automatically pass its `&T::IID` to the `riid` parameter resulting in a much more ergonomic API. Also annotate some return-only functions with `RetVal` to make it easier to retrieve these objects.
mikebattista
approved these changes
Aug 27, 2024
|
Thanks! |
riverar
reviewed
Aug 27, 2024
|
Thanks for the feedback. @MarijnS95 could you please file a separate PR to remove the RetVal changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…position`
dcomp.handPresentation.hare missing some_COM_Outptr_annotations, turning these functions inwindows-rsto take a meaningless*mut *mut c_void. With this annotation the functions return a genericT: Interfaceand automatically pass its&T::IIDto theriidparameter resulting in a much more ergonomic API.Also annotate some return-only functions with
RetValto make it easier to retrieve these objects.