Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional RAII metadata #1895

Merged
merged 3 commits into from
May 6, 2024
Merged

Add additional RAII metadata #1895

merged 3 commits into from
May 6, 2024

Conversation

riverar
Copy link
Collaborator

@riverar riverar commented Apr 30, 2024

Closes: #1891

Adds additional RAII supporting user-mode functions that take one required parameter, and optionally a second optional nullable parameter. All others are documented as unsupported (at this time) in the mentioned issue.

@riverar riverar requested a review from mikebattista as a code owner April 30, 2024 22:00
@riverar
Copy link
Collaborator Author

riverar commented Apr 30, 2024

Not likely to compile, as a lot of the functions are not in the same type namespace. This will have to be fixed. @mikebattista heads up.

EMITWINMD : error : Failed to create source for auto types: PSID, HKL, HDIAGNOSTIC_DATA_QUERY_SESSION, HDIAGNOSTIC_REPORT, HDIAGNOSTIC_EVENT_TAG_DESCRIPTION, HDIAGNOSTIC_EVENT_PRODUCER_DESCRIPTION, HDIAGNOSTIC_EVENT_CATEGORY_DESCRIPTION, HDIAGNOSTIC_RECORD, FH_SERVICE_PIPE_HANDLE, HIMC, HPTPROVIDER, ROPARAMIIDHANDLE, JET_INSTANCE, JET_SESID not in the same namespace as CloseApi.

@riverar
Copy link
Collaborator Author

riverar commented May 1, 2024

Moved the aforementioned types closer to their creation/destruction functions. This is a breaking change, heads up @mikebattista @kennykerr @AArnott

mikebattista
mikebattista previously approved these changes May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RAIIFree implies InvalidHandleValue
3 participants