AddSAPI Engine-Level Interfaces #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome. Thanks! I did notice a bunch of removals when only including sapiddk.h and using the latest version. I'm not familiar enough with the API to know if that's expected or not. What you have looks good in terms of adding the missing APIs while preserving what's there already. |
mikebattista
approved these changes
Nov 14, 2023
|
Wow, that's quick, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1736.
I must say that I bumped into one obscure issue though. I had to add
#define _SAPI_VER 0x053explicitly. The default of sapi.h is#define _SAPI_VER 0x054, but that seems to result in a scrape result that is almost half the size of when using version 5.3. I wonder why this is.Note that sapiddk.h includes sapi.h which includes sapi53.h when
_SAPI_VERis defined as such.