Revert "Initial support for GDI+ (#1679)" #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0c63f94.
mikebattista
approved these changes
Aug 18, 2023
|
Should we re-open #1287? |
|
@elachlan Oops, thanks for the heads up. Done. Will get that fixed up in the next few days, tricker than normal due to the flat API not being cleanly separate from the C++ goop. |
|
Thanks for looking at it. It does seem a bit of a hassle trying to wrangle object oriented code to functional. Even if it's just the method calls. |
|
Yes thanks for looking at it. I got stuck trying to add them so was happy to see you got farther than I did. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting 0c63f94 to restore branch status. We'll take another whack at GDI+ shortly.