Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup the enums.json to make sure it validates #1355

Merged
merged 2 commits into from
Nov 29, 2022
Merged

cleanup the enums.json to make sure it validates #1355

merged 2 commits into from
Nov 29, 2022

Conversation

elachlan
Copy link
Contributor

@elachlan elachlan commented Nov 4, 2022 •
edited
Loading

cleaning up mistakes in the enums.json

Unknown differences found:
Windows.Win32.System.Com.ITypeInfo.GetImplTypeFlags : pImplTypeFlags...Int32* => IMPLTYPEFLAGS*
Windows.Win32.System.Ole.OLEUIBUSYA.dwFlags...System.UInt32 => Windows.Win32.System.Ole.BUSY_DIALOG_FLAGS
Windows.Win32.System.Ole.OLEUIBUSYW.dwFlags...System.UInt32 => Windows.Win32.System.Ole.BUSY_DIALOG_FLAGS
Windows.Win32.System.Ole.ICreateTypeInfo.SetImplTypeFlags : implTypeFlags...Int32 => IMPLTYPEFLAGS

mikebattista
mikebattista requested changes Nov 4, 2022
View reviewed changes
Copy link
Collaborator

@mikebattista mikebattista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This changes the metadata, though, so you'll need to update the baseline.

@elachlan elachlan requested a review from mikebattista November 4, 2022 23:47
mikebattista
mikebattista requested changes Nov 7, 2022
View reviewed changes
Copy link
Collaborator

@mikebattista mikebattista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd expect 5 diffs but only see 3. Are there bugs in the missing 2?

@elachlan
Copy link
Contributor Author

elachlan commented Nov 7, 2022

I'd expect 5 diffs but only see 3. Are there bugs in the missing 2?

Thanks, I'll check over it and get back to you here.

@elachlan elachlan requested a review from mikebattista November 7, 2022 23:48
@elachlan
Copy link
Contributor Author

I am unsure why those changes are not showing up.

mikebattista
mikebattista approved these changes Nov 29, 2022
View reviewed changes
generation/WinSDK/enums.json Show resolved Hide resolved
@mikebattista mikebattista merged commit 22fe1a4 into microsoft:main Nov 29, 2022
@elachlan elachlan deleted the enum-cleanup branch November 29, 2022 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikebattista mikebattista mikebattista approved these changes

@chenss3 chenss3 Awaiting requested review from chenss3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elachlan @mikebattista