Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced PreserveSig usage with explicit attributes #1321

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Replaced PreserveSig usage with explicit attributes #1321

merged 1 commit into from
Oct 21, 2022

Conversation

mikebattista
Copy link
Collaborator

Fixed #1315.

riverar
riverar approved these changes Oct 21, 2022
View reviewed changes
Copy link
Collaborator

@riverar riverar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Is everyone happy with those names? Naming things is hard, now is a good time to scrutinize the names before it goes out.

@mikebattista
Copy link
Collaborator Author

Yes I'm happy with the names.

@mikebattista mikebattista merged commit fa752cb into main Oct 21, 2022
@mikebattista mikebattista deleted the mikebattista/fixpreservesig branch October 21, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennykerr kennykerr kennykerr approved these changes

@riverar riverar riverar approved these changes

@AArnott AArnott AArnott approved these changes

@chenss3 chenss3 Awaiting requested review from chenss3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Annotate members that return failing HRESULTs in success paths
4 participants
@mikebattista @AArnott @riverar @kennykerr