Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

newdev missing enums #1617

Closed
Nuklon opened this issue Jul 13, 2023 · 0 comments
Closed

newdev missing enums #1617

Nuklon opened this issue Jul 13, 2023 · 0 comments
Assignees
@mikebattista
Labels
missing enum An enum is missing for constant parameters

Comments

@Nuklon
Copy link
Contributor

Nuklon commented Jul 13, 2023

Actual behavior

The flags of both these types are generated as uints.
https://learn.microsoft.com/en-us/windows/win32/api/newdev/nf-newdev-diuninstalldrivera#parameters
https://learn.microsoft.com/en-us/windows/win32/api/newdev/nf-newdev-diinstalldriverw#parameters

Expected behavior

Generate as flagged enum.

Repro steps

  1. NativeMethods.txt content:
DIURFLAG_*
DIIDFLAG_*

Context

  • CsWin32 version: 0.3.18-beta+dc807e7787
  • Target Framework: net 6.0
  • LangVersion (if explicitly set by project): latest
@Nuklon Nuklon added the bug Something isn't working label Jul 13, 2023
@AArnott AArnott transferred this issue from microsoft/CsWin32 Jul 13, 2023
@AArnott AArnott added the missing enum An enum is missing for constant parameters label Jul 13, 2023
@riverar riverar removed the bug Something isn't working label Jul 13, 2023
@mikebattista mikebattista self-assigned this Jul 13, 2023
mikebattista added a commit that referenced this issue Jul 13, 2023
@mikebattista
Added flags property for #1617.
d9a9f60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikebattista mikebattista

Labels
missing enum An enum is missing for constant parameters
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@AArnott @riverar @mikebattista @Nuklon