Skip to content

Commit

Permalink
Revert [RetVal] annotation for multi-output `DCompositionGetStatist…
Browse files Browse the repository at this point in the history
…ics()`

This function returns multiple values via multiple mutable pointer
arguments, besides the annotated `frameStats` parameter not being the
last parameter.

Revert it because it has no effect on `windows-rs` and could even
break in the future, because it's not intended to be used this way.
  • Loading branch information
MarijnS95 committed Sep 4, 2024
1 parent 6dbe97c commit 00c9911
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion generation/WinSDK/emitter.settings.rsp
Original file line number Diff line number Diff line change
Expand Up @@ -986,7 +986,6 @@ IWICImagingFactory::CreateDecoderFromFilename::pguidVendor=[Optional]
DCompositionCreateDevice::dcompositionDevice=[ComOutPtr]
DCompositionCreateDevice2::dcompositionDevice=[ComOutPtr]
DCompositionCreateDevice3::dcompositionDevice=[ComOutPtr]
DCompositionGetStatistics::frameStats=[RetVal]
DCompositionGetTargetStatistics::targetStats=[RetVal]
CreatePresentationFactory::presentationFactory=[ComOutPtr]
IPresentationManager::GetPresentRetiringFence::fence=[ComOutPtr]
Expand Down
1 change: 0 additions & 1 deletion scripts/ChangesSinceLastRelease.txt
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
# Annotate ComOutPtr in CompositionSwapchain and DirectComposition
Windows.Win32.Graphics.CompositionSwapchain.Apis.CreatePresentationFactory : presentationFactory : [Out] => [ComOutPtr,Out]
Windows.Win32.Graphics.CompositionSwapchain.IPresentationManager.GetPresentRetiringFence : fence : [Out,RetVal] => [ComOutPtr,Out,RetVal]
Windows.Win32.Graphics.DirectComposition.Apis.DCompositionGetStatistics : frameStats : [Out] => [Out,RetVal]
Windows.Win32.Graphics.DirectComposition.Apis.DCompositionGetTargetStatistics : targetStats : [Out] => [Out,RetVal]
Windows.Win32.Graphics.DirectComposition.IDCompositionDevice.GetFrameStatistics : statistics : [Out] => [Out,RetVal]
Windows.Win32.Graphics.DirectComposition.IDCompositionDevice2.GetFrameStatistics : statistics : [Out] => [Out,RetVal]
Expand Down

0 comments on commit 00c9911

Please sign in to comment.