Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORT Update: Create MLGraphBuilder for every model builder #21

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

ibelem
Copy link
Contributor

@ibelem ibelem commented Jul 26, 2024

Fix #20 Error: "This MLGraphBuilder has already built a graph"

This PR updated the internal ONNX Runtime Web dists built with change of onnxruntime/pull/21514 Create MLGraphBuilder for every model builder by @Honry . There is no error for SA and other dev preview demos on Canary 129.0.6617.0 .

Reference: webmachinelearning/webnn#717 Allow MLGraphBuilder.build() to be called only once

@fdwr @Adele101 Please only merge this PR if no further changes in microsoft/onnxruntime#21514 , or we need to continute to update the ORT dists based on your review feedback.

Copy link
Collaborator

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 TY. Will wait for other ORT CR to complete to ensure no other changes to it.

@fdwr
Copy link
Collaborator

fdwr commented Aug 6, 2024

Merged microsoft/onnxruntime#21514.
Now merging this.

@fdwr fdwr merged commit bfd159c into microsoft:main Aug 6, 2024
1 check passed
@ibelem ibelem deleted the mlgraphbuilder branch September 25, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants