Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NtCreateFile function enums #15

Closed
4 tasks
AArnott opened this issue Jan 24, 2023 · 5 comments
Closed
4 tasks

NtCreateFile function enums #15

AArnott opened this issue Jan 24, 2023 · 5 comments
Assignees
Labels
missing api Some documented API is missing from the metadata

Comments

@AArnott
Copy link
Member

AArnott commented Jan 24, 2023

The NtCreateFile method parameters could use some enum love:

See also discussion in microsoft/win32metadata#1440.

If NtCreateFile is in the WDK, it's already in the win32metadata, so... do we remove it, or fix the enums?

@ChrisDenton
Copy link

NtCreateFile is in both the WDK and the SDK. However, the WDK has more related definitions than the SDK.

@mikebattista mikebattista self-assigned this Jan 25, 2023
@mikebattista
Copy link
Contributor

Keeping this issue here since shared definitions should be consolidated into the SDK metadata.

@kennykerr
Copy link

I think we should remove this from the Win32 metadata and add it to the WDK metadata, since there are plenty other NtXxx APIs in the WDK but nothing comparable in the SDK. So the work here would be to remove it from this repo just as soon as the WDK repo add its, along with its friends.

@mikebattista
Copy link
Contributor

I will transfer to wdkmetadata then and add a task to the item to remove it from the SDK before completing it.

@mikebattista mikebattista transferred this issue from microsoft/win32metadata Feb 22, 2023
@mikebattista mikebattista added the missing api Some documented API is missing from the metadata label Feb 27, 2023
mikebattista added a commit to microsoft/win32metadata that referenced this issue Mar 30, 2023
@kennykerr
Copy link

So the function was removed from the win32 metadata and added to the wdk metadata? We'll need a matching release of both to avoid a missing function issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
missing api Some documented API is missing from the metadata
Projects
None yet
Development

No branches or pull requests

4 participants