Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare vswhere and vswhere.lib to be Vulcan ready #289

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

skylarnam
Copy link
Contributor

We have received multiple APISCan violations on Azure DevOps, and one of the files that were flagged was vswhere.exe.
In order to fix the improperfileformat issues, we need to make sure to create Vulcan ready files.

For C/C++ and Managed C++ Modules, we should perform a couple of actions in order to make files Vulcan-ready:

  1. We need to pass the /Zi flag for all native modules (except DLLs that only contain resources) when compiling to produce a separate PDB file that contains all the symbolic debugging information for use with the debugger.
  1. We need to pass the /profile flag to produce an output file when linking that can be used with the Performance Tools profiler.

The PR addresses the two actions and adds the appropriate compiler and linker flags.

@skylarnam skylarnam changed the title Prepare vswhere and vswhere.lib to be vulcan ready Prepare vswhere and vswhere.lib to be Vulcan ready Apr 6, 2023
@heaths heaths merged commit c7a417b into main Apr 6, 2023
@heaths heaths deleted the dev/sknam/vulcan-ready branch April 6, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants