Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New -find feature allows searches in parent directories #171

Closed
heaths opened this issue Jan 25, 2019 · 0 comments · Fixed by #172
Closed

New -find feature allows searches in parent directories #171

heaths opened this issue Jan 25, 2019 · 0 comments · Fixed by #172

Comments

@heaths
Copy link
Member

heaths commented Jan 25, 2019

If you were to call vswhere -find ..\**\whatever.exe, vswhere will happily walk the directory tree from the parent directory of instances. This isn't a security problem since the account running vswhere needs permissions to enumerate those directories as well as to read/execute any results, but is still something we should probably prevent in the initial offering to avoid an awkward change to block this unsupported case in the future.

heaths added a commit that referenced this issue Jan 26, 2019
Fixes #171. Also fixes cases of subsequent directory separators.
heaths added a commit that referenced this issue Jan 28, 2019
Fixes #171. Also fixes cases of subsequent directory separators.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant