Enable source-build pre-built detection

[NikolaMilosavljevic]

Summary of the changes

The goal is to enable per-repo source-build to detect prebuilt packages.

Fixes: #4405

[Evangelink]

@NikolaMilosavljevic I am a bit short in time today but if the issue is not fixed on Monday, I will have a look then at what's failing. Sorry for the delay!

[NikolaMilosavljevic]

@NikolaMilosavljevic I am a bit short in time today but if the issue is not fixed on Monday, I will have a look then at what's failing. Sorry for the delay!

The latest error is:

NuGet.Packaging.Core.PackagingException: Attempted to pack multiple files into the same location(s). The following destinations were used multiple times: contentFiles\any\netcoreapp3.1\TestHostNetFramework\System.ValueTuple.dll

This was caused by the upgrade of Microsoft.Extensions.DependencyModel package from 3.0.0-preview4-27615-11 to 6.0.0. New package brings a transitive dependency on System.ValueTuple, besides others.

NuGet packaging process fails as there are now two System.ValueTuple instances in layout:

artifacts\bin\Microsoft.TestPlatform.CLI\Debug\net472\System.ValueTuple.dll
artifacts\bin\Microsoft.TestPlatform.CLI\Debug\net472\NETStandard.Library\System.ValueTuple.dll

Nuspec is trying to include both files into nupkg, at the same location:

vstest/src/package/Microsoft.TestPlatform.CLI/Microsoft.TestPlatform.CLI.nuspec

Lines 127 to 128 in c26b70a

	<file src="net472\NETStandard.Library\**\*.dll" exclude="**\mscorlib.dll;**\*.xml" target="contentFiles\any\netcoreapp3.1\TestHostNetFramework" />
	<file src="net472\System*.dll" target="contentFiles\any\netcoreapp3.1\TestHostNetFramework" />

One way to fix this is to modify the second line and add exclusions for System.ValueTuple.dll and any other duplicate files.

@Evangelink @mmitche would this be the best solution?

[NikolaMilosavljevic]

@Evangelink now the tests are failing - I see the following in my local run:

Test Output: Microsoft (R) Test Execution Command Line Tool Version 17.7.0-dev (x64) Copyright (c) Microsoft Corporation. All rights reserved. Starting test execution, please wait... A total of 1 test files matched the specified pattern. 
Standard Error: System.IO.FileNotFoundException: Could not load file or assembly 'System.Text.Json, Version=6.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'. The system cannot find the file specified. File name: 'System.Text.Json, Version=6.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' at Microsoft.Extensions.DependencyModel.DependencyContextJsonReader.Read(Stream stream) at 

We are upgrading Microsoft.Extensions.DependencyModel package from 3.0.0-preview4-27615-11 to 6.0.0 which removes Newtonsoft.Json dependency, and adds System.Text.Json and System.Text.Encodings.Web dependencies. I tried adding these to the CLI package, https://github.com/microsoft/vstest/blob/main/src/package/Microsoft.TestPlatform.CLI/Microsoft.TestPlatform.CLI.csproj, without success.

[Evangelink]

We are upgrading Microsoft.Extensions.DependencyModel package from 3.0.0-preview4-27615-11 to 6.0.0 which removes Newtonsoft.Json dependency, and adds System.Text.Json and System.Text.Encodings.Web dependencies.

I am wondering if that's not going to be a blocker for us as this would bring different dependencies to the user bin and so potentially conflict with their setup. @nohwnd What's your feeling on that?

[NikolaMilosavljevic]

We are upgrading Microsoft.Extensions.DependencyModel package from 3.0.0-preview4-27615-11 to 6.0.0 which removes Newtonsoft.Json dependency, and adds System.Text.Json and System.Text.Encodings.Web dependencies.

I am wondering if that's not going to be a blocker for us as this would bring different dependencies to the user bin and so potentially conflict with their setup. @nohwnd What's your feeling on that?

This package upgrade, to 6.0.0 was suggested as an alternative to picking live bits from runtime repo, which would have required runtime repo dependency. It needs to be a version of the package that is available in SBRP, so the source-build works fine: https://github.com/dotnet/source-build-reference-packages/tree/main/src/referencePackages/src/microsoft.extensions.dependencymodel

I checked older stable versions of this package and even version 3.0.0 has a dependency on System.Text.Json which further depends on System.Text.Encodings.Web.

[NikolaMilosavljevic]

I've updated this PR to revert the Microsoft.Extensions.DependencyModel dependency to the original version. I will create a separate issue for resolving this dependency.

[NikolaMilosavljevic]

I've updated this PR to revert the Microsoft.Extensions.DependencyModel dependency to the original version. I will create a separate issue for resolving this dependency.

Now, it's all green, all checks have passed - @Evangelink I don't have permissions to merge this PR - if you're OK with the changes, can you merge it?

[Evangelink]

Thank you so much for all the work here @NikolaMilosavljevic! <3