Removed TypesToLoadAttribute from ObjectModel.
#2674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haplois
requested review from
jfleisher,
Sanan07,
shyamnamboodiripad and
AbhitejJohn
Sanan07
suggested changes
Dec 14, 2020
Sanan07
reviewed
Dec 14, 2020
Sanan07
reviewed
Dec 14, 2020
Sanan07
reviewed
Dec 14, 2020
...ctors/Microsoft.TestPlatform.Extensions.EventLogCollector/Properties/TypesToLoadAttribute.cs
Show resolved
Hide resolved
Haplois
force-pushed
the
fix/removed-types-to-load
branch
from
4bc9c6e to
9bb5f24
Compare
Sanan07
approved these changes
Dec 14, 2020
peterwald
reviewed
Dec 14, 2020
src/Microsoft.TestPlatform.ObjectModel/Utilities/AssemblyHelper.cs
Outdated
Show resolved
Hide resolved
peterwald
approved these changes
Dec 14, 2020
Haplois
force-pushed
the
fix/removed-types-to-load
branch
2 times, most recently
from
e6baec8 to
565e9ba
Compare
* Removed TypesToLoadAttribute from ObjectModel, and moved the functionallity into adapters themselves.
Haplois
force-pushed
the
fix/removed-types-to-load
branch
from
565e9ba to
18e365e
Compare
|
Hello @Haplois! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
...ctors/Microsoft.TestPlatform.Extensions.EventLogCollector/Properties/TypesToLoadAttribute.cs
Show resolved
Hide resolved
src/Microsoft.TestPlatform.Extensions.BlameDataCollector/Properties/TypesToLoadAttribute.cs
Show resolved
Hide resolved
jakubch1
added a commit
that referenced
this pull request
Feb 5, 2021
* Update dependencies from https://github.com/dotnet/arcade build 20201130.3 (#2659) Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild From Version 1.0.0-beta.20570.10 -> To Version 1.0.0-beta.20580.3 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Updating Microsoft.VisualStudio.TraceDataCollector source (#2663) * Getting Microsoft.VisualStudio.TraceDataCollector from CodeCoverageExternals instead of TestPlatformExternals, * Signing TraceDataCollector from the right path, * Removing already signed dlls, * Not signing corelib.net, * Removing files from the list as they are not present, Co-authored-by: faisal <faisalhafeez@microsoft.com> * Fixed "issue" pluralization in write-release-notes.ps1 (#2665) * Fixed "issue" pluralization in write-release-notes.ps1 Co-authored-by: Medeni Baykal <433724+Haplois@users.noreply.github.com> * Bumping Fakes TestRunnerHarness version (#2661) * Implement Workitem support in TRX logger (#2666) * Implemented Workitem support in TRX logger * Renamed Workitem to WorkItem Co-authored-by: Flepp Jann <JFlepp@Hamilton.ch> * Do not merge logs from code coverage (#2671) * Early testhost startup performance work (#2584) * Removed TypesToLoadAttribute from ObjectModel. (#2674) * Removed TypesToLoadAttribute from ObjectModel, and moved the functionallity into adapters themselves. * Attribute refactoring (#2676) * Getting TraceDataCollector from nuget (#2678) * Removing TraceDataCollector project, * Getting tracedatacollector from nuget, * Removing signing of codecoverage libs as they are already signed, updating codecoverage version, * fixing path to tracedatacollector, * Fixing acceptance tests, Co-authored-by: faisal <faisalhafeez@microsoft.com> * Adding environment variable used during build process, (#2679) * Removing TraceDataCollector project, * Getting tracedatacollector from nuget, * Removing signing of codecoverage libs as they are already signed, updating codecoverage version, * fixing path to tracedatacollector, * Fixing acceptance tests, * Setting TraceDataCollectorPackagesDir vairable which is used in pipeline, * Fixing environment variable, * Fixing path, once again, Co-authored-by: faisal <faisalhafeez@microsoft.com> * Update dependencies from https://github.com/dotnet/arcade build 20201221.2 (#2680) Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild From Version 1.0.0-beta.20580.3 -> To Version 1.0.0-beta.20621.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Upgrade CC and CLR IE versions (#2681) Co-authored-by: Jakub Chocholowicz <jachocho@microsoft.com> * Fixed assembly names of TestHost executables (#2682) * Upgrade fakes version (#2683) Co-authored-by: Jakub Chocholowicz <jachocho@microsoft.com> * Upgrade CC to 16.9.0-beta.20630.1 (#2684) Co-authored-by: Jakub Chocholowicz <jachocho@microsoft.com> * Loc Update (#2685) Co-authored-by: Cristiano Suzuki <crsuzuki@microsoft.com> * Create AzureDevOps.yml * Update AzureDevOps.yml * Update AzureDevOps.yml * Update AzureDevOps.yml * Delete AzureDevOps.yml * Fix nuget feed (#2697) * Removing deprecated mygets and adding new nuget sources * Upgrade CC components (#2698) * Upgrade CC components * Revert nuget changes * Refactor it Co-authored-by: Jakub Chocholowicz <jachocho@microsoft.com> * Update dependencies from https://github.com/dotnet/arcade build 20210113.4 (#2696) Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild From Version 1.0.0-beta.20621.2 -> To Version 1.0.0-beta.21063.4 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Create AzureDevOps.yml * Update AzureDevOps.yml * Update AzureDevOps.yml * Update AzureDevOps.yml * Update AzureDevOps.yml * Update AzureDevOps.yml * Update AzureDevOps.yml changed to my repo * Update AzureDevOps.yml * Add integration tests for dotnet test (#2689) * Add integration tests for dotnet test * Use relative paths and correct proj * Update to latest .NET 6 * Install 5.0.1 runtime * Add parametrized project * Updated build status badge. (#2709) * Updated build status badge. * Update dependencies from https://github.com/dotnet/arcade build 20210121.4 (#2712) Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild From Version 1.0.0-beta.21063.4 -> To Version 1.0.0-beta.21071.4 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/arcade build 20210122.7 (#2713) Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild From Version 1.0.0-beta.21063.4 -> To Version 1.0.0-beta.21072.7 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Medeni Baykal <433724+Haplois@users.noreply.github.com> * Update azure-pipelines.yml for Azure Pipelines (#2715) * Add metrics for datacollector.exe - provides information about profilers (#2705) * Initial version of metrics for DC profiling * Tests * Push fixes to make linux build * provide telemetry opted in flag * Small refactoring * Change name * Upgrade CC comp * Move to guids * Revert lang change * Fixing descriptions * Last changes Co-authored-by: Jakub Chocholowicz <jachocho@microsoft.com> * Added git branch and commit NuGet packages (#2716) * vstest.console: CommandLineOptions: preserve stacktrace on re-throw (CA2200) (#2606) * vstest.console: CommandLineOptions: preserve stacktrace on re-throw (CA2200) * Update AzureDevOps.yml * Update AzureDevOps.yml * Move FQN related code into a separate NuGet package (#2714) * Removed ManagedNameUtilities from ObjectModel in order to restore compatibility with older versions. * Added `Microsoft.TestPlatform.AdapterUtilities`. * Added `net20` and `net35` support to the code. * Including `Microsoft.TestPlatform.AdapterUtilities` in signing (#2719) * Included missing assemblies in signing. * Updating nuget Pdb2Pdb package (#2720) * Adding new Pdb2Pdb package and change to licence tag because of warning * Fixing license * Formating fixes Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: fhnaseer <fhnaseer@live.com> Co-authored-by: faisal <faisalhafeez@microsoft.com> Co-authored-by: Adam Ralph <adam@adamralph.com> Co-authored-by: Medeni Baykal <433724+Haplois@users.noreply.github.com> Co-authored-by: Vritant Bhardwaj <vrbhardw@microsoft.com> Co-authored-by: jflepp <jflepp@users.noreply.github.com> Co-authored-by: Flepp Jann <JFlepp@Hamilton.ch> Co-authored-by: Codrin-Victor Poienaru <cvpoienaru@gmail.com> Co-authored-by: Jakub Chocholowicz <jachocho@microsoft.com> Co-authored-by: Cristiano Suzuki <cristianosuzuki77@gmail.com> Co-authored-by: Cristiano Suzuki <crsuzuki@microsoft.com> Co-authored-by: Pavel Horak <22235234+pavelhorak@users.noreply.github.com> Co-authored-by: Sanan Yuzbashiyev <Sanan07@users.noreply.github.com> Co-authored-by: Jakub Jareš <me@jakubjares.com> Co-authored-by: Tom Deseyn <tom.deseyn@gmail.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
TypesToLoadAttributefrom ObjectModel, and moved the functionality into adapters themselves to fix compatibility issues introduced in #2537.