Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestPluginCache and other dependencies refactoring #2537

Merged
merged 36 commits into from
Nov 19, 2020
Merged

TestPluginCache and other dependencies refactoring #2537

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
4eb1f76
Test space added
Sanan07 May 26, 2020
fd6cbbf
Exception handler was added to catch AccessDeniedException while tryi…
Sanan07 Jun 3, 2020
026226a
Remove unnecessary space
Sanan07 Jun 3, 2020
104ffc0
Deleted unnecessary test. Changed console message and corrected folde…
Sanan07 Jun 3, 2020
2608e88
Remove unnecessary dot
Sanan07 Jun 3, 2020
f8d8aa1
Removed unnecessary lines and usings and coreccted exception message
Sanan07 Jun 3, 2020
0f6bf18
Removed unnecessary line
Sanan07 Jun 3, 2020
d1803c9
Updating resource files
Sanan07 Jun 4, 2020
bf0cacf
New exception handling was added
Sanan07 Jun 11, 2020
3ee2dc7
Merge branch 'master' into accessDeniedException
Sanan07 Jun 11, 2020
2582e75
Formatted exception message
Sanan07 Jun 11, 2020
030fda6
Merge branch 'accessDeniedException'
Sanan07 Jul 2, 2020
ea180c3
Merge branch 'master' of https://github.com/microsoft/vstest
Sanan07 Jul 16, 2020
7a896ff
Merge branch 'master' of https://github.com/microsoft/vstest
Sanan07 Jul 28, 2020
8ea1932
Merge branch 'master' of https://github.com/microsoft/vstest
Sanan07 Jul 31, 2020
740ae68
Merge branch 'master' of https://github.com/microsoft/vstest
Sanan07 Aug 6, 2020
73e626f
Small improvements in TestPluginDiscoverer about loading types from a…
Sanan07 Aug 17, 2020
c0b9e3d
Small performance improvements
Sanan07 Aug 19, 2020
2c40e69
TestExtensions - refactored typeof operations
Sanan07 Aug 25, 2020
a76ee21
Added new assembly level attribute to define excat types which should…
Sanan07 Oct 6, 2020
efcfb64
Commenting piece of code which cause build error
Sanan07 Oct 7, 2020
6512ee6
Restored previous implementation
Sanan07 Oct 7, 2020
e7839bd
Changed methods because previous changes had exception while building…
Sanan07 Oct 7, 2020
61622b4
Merge branch 'master' of https://github.com/microsoft/vstest into dev…
Sanan07 Oct 7, 2020
51ced2e
Added missing attribute to blame, event collector and code coverage
Sanan07 Oct 8, 2020
e130cdd
Merge branch 'dev/sayuzbas/test-plugin-cache' of https://github.com/m…
Sanan07 Oct 14, 2020
6170b27
Redesigned custom attribute to specify interesting types themselves
Sanan07 Oct 14, 2020
3c89fb9
More improvements
Sanan07 Oct 14, 2020
f72333b
Fixed cast exception
Sanan07 Oct 15, 2020
e60aea5
GetTypes returned to previous implementation and removed unncessary S…
Sanan07 Oct 16, 2020
e9c3ccc
changed global.json
Sanan07 Oct 20, 2020
3309572
returned to previous version in global.json
Sanan07 Oct 20, 2020
0bfaa31
Merge branch 'master' of https://github.com/microsoft/vstest into dev…
Sanan07 Oct 21, 2020
ef7d60f
Merge branch 'master' of https://github.com/microsoft/vstest into dev…
Sanan07 Nov 9, 2020
e081c3f
PR review fix
Sanan07 Nov 19, 2020
20655e7
Merge branch 'master' of https://github.com/microsoft/vstest into dev…
Sanan07 Nov 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Microsoft.TestPlatform.Common/ExtensionFramework/TestPluginDiscoverer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ private void GetTestExtensionsFromAssembly<TPluginInfo, TExtension>(Assembly ass
return;
}

if (types != null && types.Count() > 0)
if (types != null && types.Any())
{
foreach (var type in types)
{
Expand Down
3 changes: 1 addition & 2 deletions src/Microsoft.TestPlatform.ObjectModel/Utilities/TypesToLoadAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
namespace Microsoft.VisualStudio.TestPlatform.ObjectModel.Utilities
{
using System;
using System.Collections.Generic;

/// <summary>
/// Custom Attribute to specify the exact types which should be loaded from assembly
Expand All @@ -18,6 +17,6 @@ public TypesToLoadAttribute(params Type[] types)
Types = types;
}

public IEnumerable<Type> Types { get; }
public Type[] Types { get; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer immutable.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IEnumerable, is also not immutable isn't it? But does it matter? How would this collection change to cause problems? We would need a static ctor to find it and modify it on assembly load?

}
}