Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/source-build-reference-packages #15016

Merged
merged 3 commits into from
Feb 27, 2025

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Feb 24, 2025

This pull request updates the following dependencies

From https://github.com/dotnet/source-build-reference-packages

…ence-packages build 20250219.1

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 10.0.611203 -> To Version 10.0.611901
@nohwnd
Copy link
Member

nohwnd commented Feb 24, 2025

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

…ence-packages build 20250225.2

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 10.0.611203 -> To Version 10.0.612502
@MichaelSimons
Copy link
Member

MichaelSimons commented Feb 27, 2025

@nohwnd, the following changes need to be made to https://github.com/microsoft/vstest/blob/main/eng/SourceBuildPrebuiltBaseline.xml. I tried to update the PR, but don't have access.

-    <!-- Caused by dependency on System.ComponentModel.Composition.8.0.0. This version is overridden in full source-build. -->
-    <UsagePattern IdentityGlob="Microsoft.NETCore.Platforms/2.0.0" />
+    <!-- Caused by dependency on System.ComponentModel.Composition. This version is overridden in full source-build. -->
+    <UsagePattern IdentityGlob="Microsoft.NETCore.Platforms/*" />
     <!-- This version is overridden in full source-build. -->
-    <UsagePattern IdentityGlob="System.ComponentModel.Composition/8.0.0" />
-    <!-- Caused by dependency on System.ComponentModel.Composition.8.0.0. This version is overridden in full source-build. -->
-    <UsagePattern IdentityGlob="System.Security.AccessControl/8.0.0" />
-    <!-- Caused by dependency on System.ComponentModel.Composition.8.0.0. This version is overridden in full source-build. -->
-    <UsagePattern IdentityGlob="System.Security.Permissions/8.0.0" />
-    <!-- Caused by dependency on System.ComponentModel.Composition.8.0.0. This version is overridden in full source-build. -->
-    <UsagePattern IdentityGlob="System.Security.Principal.Windows/8.0.0" />
-    
+    <UsagePattern IdentityGlob="System.ComponentModel.Composition/*" />
+    <!-- Caused by dependency on System.ComponentModel.Composition. This version is overridden in full source-build. -->
+    <UsagePattern IdentityGlob="System.Security.AccessControl/*" />
+    <!-- Caused by dependency on System.ComponentModel.Composition. This version is overridden in full source-build. -->
+    <UsagePattern IdentityGlob="System.Security.Permissions/*" />
+    <!-- Caused by dependency on System.ComponentModel.Composition. This version is overridden in full source-build. -->
+    <UsagePattern IdentityGlob="System.Security.Principal.Windows/*" />
 
     <!-- Caused by multi-targeting source build for repo builds/CI. Product source build only targets NetCurrent. -->
     <UsagePattern IdentityGlob="Microsoft.Diagnostics.NETCore.Client/0.2.*" />
     <UsagePattern IdentityGlob="Microsoft.AspNetCore.App.Ref/8.0.*" />
     <UsagePattern IdentityGlob="Microsoft.NetCore.App.Ref/8.0.*" />
     <UsagePattern IdentityGlob="Microsoft.NETCore.App.Host.linux-x64/8.0.*" />
-    <UsagePattern IdentityGlob="Microsoft.Extensions.FileSystemGlobbing/2.0.0" />
-    <UsagePattern IdentityGlob="System.Text.Json/4.7.0" />
-    <UsagePattern IdentityGlob="Microsoft.Extensions.DependencyModel/3.1.0*" />
+    <UsagePattern IdentityGlob="Microsoft.Extensions.FileSystemGlobbing/*" />
+    <UsagePattern IdentityGlob="System.Text.Encodings.Web/*" />
+    <UsagePattern IdentityGlob="System.Text.Json/*" />
+    <UsagePattern IdentityGlob="Microsoft.Extensions.DependencyModel/*" />
   </IgnorePatterns>
 </UsageData>

The reason for this is because these changed entries have corresponding Version.Details.xml entries (or are transitive dependencies) and therefore get lifted to the latest during a full source-build. Because of that, they are false positives in the repo prebuilt detection thus they appear here. Hardcoding version numbers creates a maintenance burdens.

@nohwnd nohwnd merged commit 0d31583 into main Feb 27, 2025
3 of 5 checks passed
@nohwnd nohwnd deleted the darc-main-d740052f-4056-41a7-b36d-d29e94df1757 branch February 27, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants