refactor find widget to support multiple selection find/replace #98884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hey there! I’m just checking in to see if there’s anything I missed to get this into review. I see there are quite a few open PRs, so if it’s just a matter of time that’s totally cool 😎 But if I have missed something I’ll happily get to it. |
|
@jodyheavener thanks for your contribution, the code is great! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21792
👋 This PR updates the find widget to support find/replace within multiple selections, where currently only whole-document or a single selection is permitted. The updated widget maintains existing functionality and supports all search options with its new functionality, such as case matching and regular expressions.
Here's a link (.mov) to a video with a full demonstration.