Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes clicking on problems filter inputbox makes problems panel callapse #96203

Merged
merged 2 commits into from
Apr 27, 2020

Conversation

jeanp413
Copy link
Contributor

This PR fixes #96009

@sandy081
Copy link
Member

Seems the fix will fix the issue but trying to understand why the click on input box is triggering collapse button?

@sandy081 sandy081 added this to the April 2020 milestone Apr 27, 2020
@jeanp413
Copy link
Contributor Author

@sandy081 The event is bubbling up so ⬇️ also gets triggered.

this._register(domEvent(this.header, 'click')
(e => {
if (!e.defaultPrevented) {
this.setExpanded(!this.isExpanded());
}
}, null));

@sandy081
Copy link
Member

Ah I see. Thanks for explanation.

Copy link
Member

@sandy081 sandy081 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandy081 sandy081 merged commit 94c469d into microsoft:master Apr 27, 2020
@jeanp413 jeanp413 deleted the fix-96009 branch April 27, 2020 08:34
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split problems panel makes filter input unclickable
3 participants