Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix VSCode can not use microphone and camera on MacOS 10.15 #95832

Closed
wants to merge 1 commit into from

Conversation

weishuyin
Copy link

@weishuyin weishuyin commented Apr 22, 2020

This PR fixes #
Start VSCode by click it's icon(DO NOT start VSCode via Terminal.app, DO NOT use code -n or other code command) on MacOS 10.15, than exec some command which use microphone, for example 'sox -d ~/test.wav'(may need to exec 'brew install sox' first) in VSCode's TERMINAL.
There is no dialog shown to request microphone permission. Command sox record nothing in output file and no errors reported, and VSCode is not on Settings → Privacy → Microphone list

With this patch, when we exec sox first time, there is a dialog shown to request microphone permission. Command sox can record, and VSCode will be on Settings → Privacy → Microphone list.

@deepak1556
Copy link
Collaborator

Thanks for the PR! but I am not really happy adding the media entitlements to VS Code since it is not necessary at the moment. The way the integrated terminal is spawned today is as forked process of code's renderer process and hence get the permissions assigned to the parent process, I would like to see if the process spawning can be fixed otherwise we can go down the entitlement road.

This is tracked under #95062

@deepak1556 deepak1556 closed this Apr 22, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants