-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix debounceEvent #9186
Fix debounceEvent #9186
Conversation
not sure why you mean by that? Do you have two listeners and one modifies the event object? |
Oh, I see - you trigger event while processing them... Can you pls add you test to this PR |
@@ -177,6 +177,33 @@ suite('Event',function(){ | |||
Errors.setUnexpectedErrorHandler(origErrorHandler); | |||
} | |||
}); | |||
|
|||
test('Debounce Event', function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since this test is async (setTimeout) you must add the done
parameter and call it. Alternatively make this test return a promise.
yeah - looks good. waiting for the builds to finish |
@f111fei - sorry we had some hiccups today. Can you rebase with master and try again? |
@jrieken I do as you say but I'm not sure if I'm right. |
LGTM - thanks for the contribution |
debounceEvent
is abnormal sometimes.Steps to Reproduce:
Here is my test case:
event.test.ts
.scripts\test
.Here is error:
was not expecting keys.
Reason:
Some code is changing
output
duringemitter.fire
Solution:
Reset
output
beforeemitter.fire