Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #88294 Add commitData in commit interface #89005

Merged
merged 6 commits into from
Feb 18, 2020
Merged

Fix #88294 Add commitData in commit interface #89005

merged 6 commits into from
Feb 18, 2020

Conversation

zjysdhr
Copy link
Contributor

@zjysdhr zjysdhr commented Jan 21, 2020

This PR fixes #88294

@zjysdhr zjysdhr requested a review from joaomoreno January 21, 2020 06:42
@msftclas
Copy link

msftclas commented Jan 21, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

@joaomoreno joaomoreno self-assigned this Jan 21, 2020
@joaomoreno joaomoreno added the git GIT issues label Jan 21, 2020
@joaomoreno joaomoreno mentioned this pull request Jan 27, 2020
Merged
@zjysdhr zjysdhr changed the title Fix #88294 Add authorName and commitData in commit interface Fix #88294 Add commitData in commit interface Jan 29, 2020
@zjysdhr
Copy link
Contributor Author

zjysdhr commented Jan 29, 2020

by #89262, we only need to add commitData.

@joaomoreno joaomoreno added this to the February 2020 milestone Feb 18, 2020
@joaomoreno joaomoreno merged commit c77f8a8 into microsoft:master Feb 18, 2020
@joaomoreno
Copy link
Member

Thanks! 👍

@zjysdhr zjysdhr deleted the issue/88294 branch February 18, 2020 09:06
@alexdima
Copy link
Member

@joaomoreno I had to revert this via aa70f38 because it was causing a test to fail, and it appeared to be a real failure, not just a test fluke.

alexdima referenced this pull request Feb 18, 2020
@alexdima
Revert "Fix #88294 Add commitData in commit interface"
aa70f38 
This reverts commit 51b8bd5.
@joaomoreno
Copy link
Member

Thanks for the heads up @alexdima

@joaomoreno
Copy link
Member

I've fixed it: the tests needed adoption.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joaomoreno joaomoreno Awaiting requested review from joaomoreno

Assignees

@joaomoreno joaomoreno

Labels
git GIT issues
Projects
None yet
Milestone
February 2020
Development

Successfully merging this pull request may close these issues.

Git Extension: Commit interface should provide date and author name
4 participants
@zjysdhr @msftclas @joaomoreno @alexdima