Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Help > Report Issue menu item when issue reporter is disabled in product.json #83561

Merged
merged 1 commit into from
Oct 29, 2019

Conversation

dalongi
Copy link
Contributor

@dalongi dalongi commented Oct 29, 2019

This PR fixes #83560

When product.json "reportIssueUrl" is not included, all other entrypoints to Issue Reporter are hidden. However, the help menu still includes it.

We should hide this menu item when Issue Reporter is disabled.

Manual Test

Issue reporter enabled

  • Use default product.json
  • Verify "Help > Report Issue" menu item shows.
  • Verify clicking "Help > Report Issue" opens the issue reporter.

Issue reporter disabled

  • Update product.json to remove "reportIssueUrl" line.
  • Verify "Help > Report Issue" menu item does not exist.

@RMacfarlane RMacfarlane self-assigned this Oct 29, 2019
Copy link
Contributor

@RMacfarlane RMacfarlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!

@RMacfarlane RMacfarlane merged commit 16ee963 into microsoft:master Oct 29, 2019
@RMacfarlane RMacfarlane added this to the October 2019 milestone Oct 29, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Help > Report Issue" menu item added when product.json disables "reportIssueUrl"
2 participants