-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tab color refinements #8238
Tab color refinements #8238
Conversation
@bgashler1 some feedback after trying it out:
Otherwise seems to work nicely 👍 |
@bpasero yeah, that's not intentional. Hopefully you can add a class that scopes this down to just tabs-enabled. |
|
||
.monaco-editor.vs-dark .scroll-decoration { | ||
box-shadow: #1E1E1E 0 6px 6px -6px inset; /* TODO: use a CSS custom property of the theme's `.monaco-editor-background` color here to blend better */ | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bpasero are these the scroll styles I changed that you mentioned in the PR? I changed these so that they would match the editor background color so that it creates a fake gradual mask over text when you've scrolled. That way the active tab, which has the same background color of the editor, will not appear to abruptly chop off text in the editor while also not creating a shadow (as it used to) which would make the tab appear on a different plane than the text.
Unfortunately, I had to hard-code these values, so in other themes than the just the default Dark and Light, it looks weird. We could just hide these display: none
, until we can get CSS custom property to give us the theme's editor base color. I'll leave that up to you.
@bgashler1 sorry, more findings after playing around with it
Given this, I wonder how to proceed. I tried to capture all the issues we currently have into #8564 Maybe we can make minimal tweaks to address those as much as possible and keep a larger overhaul for July? |
+1 for do not rush this and do it in July |
Addressing feedback on PR microsoft#8238
Fixes #7649
You'll notice that this variation of the tabs has a horizontal bar under the entire title and that only the active tab is shown boxed. It also is a darker color, matching the viewlet color. This line and the darker color combined help differentiate the find/replace widget.
Also, consequently this is a simplification of what we have already.
Before (3 colors and boxy-looking)
After (2 colors and more flat)
Also introduces
mix-blend-mode
to make tabs very responsive to themes #8151.