-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List: additionalScrollHeight #78773
List: additionalScrollHeight #78773
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not too happy about this either in code nor in the product. Here are some alternative ideas to tackle #1043:
- Add additional context menu actions on files:
New Sibling File
, etc; - Add a
Parent Folder
submenu to the file context menu, containing all actions of its parent folder; - Tell users to right click on the scrollbar, it actually behaves as if you're right clicking the root. 😆
My 2 cents: we have discussed all those alternatives in length and they are not nice. I personally found this proposed solution to be one of the best so far and would go for it. Please do not add a new menu entry. And please do not force everyone to have a root node. |
@bpasero @joaomoreno and me just discussed this offline. |
After we selfhost on this for a couple of weeks we can revert it if we hate it, or we can tune the space at the bottom. |
Cool! |
This PR adds the
additionalScrollHeight
option to thelist
and propagets it through thetree
classes. This option allows the list clients to specify additionalscrollHeight
. I decided to make this anumber
, not aboolean
since clients are in charge of the height of each element.Here the explorer also starts using this options, specifying twice the element height.
The motivation for this is to tackle #1043 so it would be easier for users to create top level elements in the full explorer by scrolling all the way down.
I tried it out and I actually like how it feels.
Let me know what you think and thanks for the review.