list.clear should clear both focus and selection in one go #78709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaomoreno
approved these changes
Aug 8, 2019
| @@ -751,7 +751,8 @@ KeybindingsRegistry.registerCommandAndKeybindingRule({ | |||
|
|
|||
| if (list.getSelection().length > 0) { | |||
| list.setSelection([]); | |||
| } else if (list.getFocus().length > 0) { | |||
| } | |||
| if (list.getFocus().length > 0) { | |||
There was a problem hiding this comment.
It was already there and I just did not remove it.
I guess all those checks do not really make sense now and should be removed.
We should just setSelection([]) and setFocus([])
joaomoreno
added
accessibility
|
I pushed a simplified approach to this. |
joaomoreno
approved these changes
Aug 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you have a tree which is both selected and focused it takes two times to press
escto first clear the focus and then the selection.This makes it harder for users to navigate up to the tree via focus. This affects accessibility and #1043 for example.
This PR changes this behavior that
escalways clears both selection and focus.