Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : Standalone Monaco text edit validation #7864

Merged
merged 1 commit into from
Jun 20, 2016
Merged

fix : Standalone Monaco text edit validation #7864

merged 1 commit into from
Jun 20, 2016
+1 −1

Conversation

basarat
Copy link
Contributor

@basarat basarat commented Jun 19, 2016 •
edited
Loading

🌹

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @alexandrudima to be a potential reviewer

@basarat
Copy link
Contributor Author

basarat commented Jun 19, 2016

I fixed this locally as well. But suggestions with textEdit still don't work (they don't even show up in the suggestion list) :-/

@basarat
Copy link
Contributor Author

basarat commented Jun 20, 2016

But suggestions with textEdit still don't work (they don't even show up in the suggestion list)

I checked. Its because of CompletionModel._filter function removing it. I'll figure that out on my own so you don't need to worry about that 🌹

@alexdima alexdima merged commit 81f2b6a into microsoft:master Jun 20, 2016
@alexdima
Copy link
Member

@basarat Thank you!

@basarat basarat deleted the patch-2 branch June 20, 2016 18:09
@alexdima alexdima added this to the June 2016 milestone Jul 1, 2016
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@alexdima alexdima

Labels
None yet
Projects
None yet
Milestone
June 2016
Development

Successfully merging this pull request may close these issues.
4 participants
@basarat @mention-bot @alexdima @msftclas