Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI support for TimeTravel Debugging #7734

Merged
merged 3 commits into from
Jun 16, 2016

Conversation

roblourens
Copy link
Member

To close #7652, @isidorn.

DebugActionsWidget.getActions is a little awkward. Another option could be saving all the actions by name and returning a new array on each call, based on the state. That could also clean up this part:
this.actions[0] = state === debug.State.Running ? this.pauseAction : this.continueAction;

Another option could be hiding the actions dynamically.

For example,

class PauseAction {
    isVisible(): boolean {
        return something.state === State.Running;
    }
}

and the inverse for ContinueAction.

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @egamma and @isidorn to be potential reviewers

@sandy081
Copy link
Member

@isidorn Pull request for you :)

@isidorn isidorn added this to the June 2016 milestone Jun 16, 2016
@isidorn isidorn merged commit e9ee991 into microsoft:master Jun 16, 2016
@isidorn
Copy link
Contributor

isidorn commented Jun 16, 2016

@roblourens great work - thanks a lot 🍻

I am making the DebugActionsWidget draggable so am rewriting parts of the code there - so I will try to make the actions toggling nicer - thanks for feedback.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI support for TimeTravel Debugging
5 participants