-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show warning for a long commit message #7399
Conversation
By analyzing the blame information on this pull request, we identified @egamma and @joaomoreno to be potential reviewers |
Hi @sijad, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
I'm not sure about the message if you could help me come up with a better one that would be great, stopwritingramblingcommitmessages:
|
Thanks, looks great! 🍻 I've added a few more changes on top:
|
Hey should this be disabled by default? Or at least a bit more generous than 50 chars? |
I just looked it up and found this conversation on SO Seems like the linux kernel contributions recommend 70-75 chars max. Those guys live on the command line where these things matter so I'm guessing we can be a little more relaxed than 50 characters. |
Looks like the git commit man page recommends 50 characters or less I gotta go retrain myself! |
Can we have this 50 character limit as a variable in the config and not hardcoded? |
@Pho3nixHun fair enough! |
Is this dead? |
fixes #7138
50 characters limit is hardcoded, should it be a configurable setting?