44146 automatically show problems panel

[sebastianwitthus]

Issue 44146:

Feature Request

When problems are matched while running a task, I'd like the Problems panel to automatically appear. This is especially useful if I have presentation.reveal set to never.

This branch adds the option revealProblem, which controls whether a task should show the problems panel. Oriented on reveal, it offers always, never and onProblem.
The reveal: silent option already triggers the showing of the terminal when problems of MarkerSeverity Error are encountered. (see terminalTaskSystem.ts ) The hints have been updated to reflect this.

[msftclas]

All CLA requirements met.

[sebastianwitthus]

alexr00: To avoid excessive DOM manipulation and/or confusing DOM handling, I no longer fire events for each problemFound (as my first suggestion did) but instead use the end-of-background-processing and end-of-task hooks already provided by the tasks.

[alexr00]

Thanks for the PR! There is a case that doesn't appear to be handled correctly though:

			"presentation": {
				"reveal": "always",
				"revealProblem": "onProblem"
			},

As discussed here this should cause the terminal to show, then the probelm panel to show if a problem occurs.

[sebastianwitthus]

I'll look into it

[sebastianwitthus]

@alexr00 I have just confirmed correct behaviour for

"presentation": {
  "reveal": "always",
  "revealProblem": "onProblem"
},

It works with both WatchingProblemCollector and StartStopProblemCollector using tsc -w and tsc, respectively. Have you triggered the WatchingProblemCollector by saving a watched file?

Edit: To clarify, the behaviour is as follows: Start of task opens the 'terminal' panel (non-sticky). End of scan (end of task for tsc, end of scan for tsc -w) closes the terminal panel and opens the 'problem' panel.

[alexr00]

Looks good!

[alexr00]

Thanks for checking that scenario. I was hitting a different issue!