Option to hide the status bar implemented #6942
Merged
+90
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kisstkondoros, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
kisstkondoros
force-pushed
the
hidestatusbar
branch
from
290380b to
48b5765
Compare
kisstkondoros
force-pushed
the
hidestatusbar
branch
from
48b5765 to
da52595
Compare
|
@kisstkondoros thanks 👍 |
|
@kisstkondoros can you merge this PR with master and resolve the conflicts? also I noticed a bug: you do not seem to read the status bar visibility setting on startup here: https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/browser/workbench.ts#L412 |
|
@bpasero Will do it, thanks for spotting the issue 👍 |
kisstkondoros
force-pushed
the
hidestatusbar
branch
from
da52595 to
a40a97c
Compare
kisstkondoros
force-pushed
the
hidestatusbar
branch
from
a40a97c to
9a7594e
Compare
|
@bpasero I've rebased the branch 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #6356