-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When wrapping with Emmet, consider the document language when setting the syntax. #68326
Conversation
@mattkwiecien Nice! Do you mind adding a test case for this in |
Absolutely! Will do either tonight or tomorrow morning. |
Added two unit tests for While I was in there, I noticed that a lot of the unit tests were re-writing existing logic in the |
@octref / @ramya-rao-a |
Just a small nitpick, looks good to me. Thanks! |
Awesome contribution, thank you! |
Thanks, really looking forward to contributing more to this great project :) |
doWrapping
was previously settingsyntax = 'html
when wrapping with abbreviations. This was resulting in bad class attribute names forjsx
files.args
parameter passed todoWrapping
.args
parameter to be undefined, so added a guard clause to ensure that it iseditor.document.languageId
.Now the
syntax
value is based on the return ofgetSyntaxFromArgs
, and if the result of this function is undefined, default to'html'
.This fixes #67098.