Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Screencast] Add border for keys #67641

Merged
merged 4 commits into from
Aug 7, 2019
Merged

[Screencast] Add border for keys #67641

merged 4 commits into from
Aug 7, 2019

Conversation

usernamehw
Copy link
Contributor

demo

@bpasero
Copy link
Member

bpasero commented Jan 31, 2019 •
edited
Loading

Maybe better show them as we show keybindings in general (keybindingWidget.ts)? Not sure how that would work in such a large size:

image

@usernamehw
Copy link
Contributor Author

usernamehw commented Jan 31, 2019 •
edited
Loading

I don't think it's viable to use the exact same style (adding a class). The sizes are different font-size/box-shadow/border-radius/padding.

This is how it looks now:
demo

It still probably needs splitting for Shift+Alt+; type of keybindings.

@joaomoreno joaomoreno added this to the Backlog milestone Jan 31, 2019
@joaomoreno
Copy link
Member

Thanks! 🍻

@joaomoreno joaomoreno modified the milestones: Backlog, July 2019, August 2019 Aug 7, 2019
@joaomoreno joaomoreno merged commit 2ca7f22 into microsoft:master Aug 7, 2019
@usernamehw usernamehw deleted the key_border branch August 7, 2019 17:06
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@joaomoreno joaomoreno

Labels
screencast-mode
Projects
None yet
Milestone
August 2019
Development

Successfully merging this pull request may close these issues.
3 participants
@usernamehw @bpasero @joaomoreno