Lock on click #66169
Merged
Lock on click #66169
+34
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sandy081 Do you want to review this or should I? |
|
@isidorn Will do. |
YisraelV
commented
Jan 9, 2019
| @@ -612,9 +601,7 @@ export class OutputService extends Disposable implements IOutputService, ITextMo | |||
| if (!preserveFocus) { | |||
| this._outputPanel.focus(); | |||
| } | |||
| }) | |||
| // Activate smart scroll when switching back to the output panel | |||
| .then(() => this.setPrimaryCursorToLastLine()); | |||
There was a problem hiding this comment.
The reason we probably called this function was to resume scrolling. Now we shouldn't call it anymore because scrolling depends only on the lock action state, and the lock state should persist between channel changes.
|
I added some comments in the code review to clarify my intention. Please let me know if it's preferred not to do it. @sandy081 I now squashed my two commit into 1 since the second one only fixed something I forgot. |
Clicking inside the output panel should set the lock on just as if the lock icon was clicked. Moving to the last line (with ctrl+end or click) should unset the lock.
|
@YisraelV I liked toggling the lock button while clicking in the panel. LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#63525