Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a terminal creation to ignore VSCode's process environment #64733

Merged
merged 3 commits into from
Jan 11, 2019

Conversation

GabeDeBacker
Copy link
Contributor

#64731 - > Allow a terminal to be created with a specific environment by not inheriting VSCode's environment.

@Tyriar Tyriar self-assigned this Dec 10, 2018
@Tyriar Tyriar added this to the December 2018 milestone Dec 10, 2018
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GabeDeBacker we just had the API call, the idea is approved and the final incarnation we landed on is pretty simply and much closer to the initial version:

export interface TerminalOptions {
    /**
     * Whether the terminal process environment should be exactly as provided in
     * `TerminalOptions.env`. When this is false (default), the environment will be based on the
     * window's environment and also apply configured platform settings like
     * `terminal.integrated.windows.env` on top.
     */
    strictEnv: boolean;
}

If that works for you we can keep working on the PR and merge it in.

@GabeDeBacker
Copy link
Contributor Author

Sorry, didn't mean to go missing in action here. I'll get on this and get it completed with the approved API design above.

@GabeDeBacker GabeDeBacker force-pushed the user/gabrield/noInheritEnv branch from 399e115 to e1d8493 Compare January 11, 2019 18:29
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works great. Merging after CI passed 😃

@Tyriar Tyriar merged commit 3703d71 into microsoft:master Jan 11, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants