-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow a terminal creation to ignore VSCode's process environment #64733
Allow a terminal creation to ignore VSCode's process environment #64733
Conversation
src/vs/workbench/parts/terminal/electron-browser/terminalProcessManager.ts
Show resolved
Hide resolved
src/vs/workbench/parts/terminal/electron-browser/terminalProcessManager.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/parts/terminal/electron-browser/terminalProcessManager.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/api/electron-browser/mainThreadTerminalService.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GabeDeBacker we just had the API call, the idea is approved and the final incarnation we landed on is pretty simply and much closer to the initial version:
export interface TerminalOptions {
/**
* Whether the terminal process environment should be exactly as provided in
* `TerminalOptions.env`. When this is false (default), the environment will be based on the
* window's environment and also apply configured platform settings like
* `terminal.integrated.windows.env` on top.
*/
strictEnv: boolean;
}
If that works for you we can keep working on the PR and merge it in.
Sorry, didn't mean to go missing in action here. I'll get on this and get it completed with the approved API design above. |
399e115
to
e1d8493
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, works great. Merging after CI passed 😃
#64731 - > Allow a terminal to be created with a specific environment by not inheriting VSCode's environment.