Fixes Git Clone Problem with Spaces

[scottymcraig]

Fixes #60472. Checks to see if there are spaces in the URL and if so, encodes them.

[vikaskyadav]

Looks good @scottymcraig

[PeterWone]

I realise my bug report describes spaces, but having seen the fundamental problem (the name can contain characters not allowed in a file path) surely you would fix it like this
await this.exec(parentPath, ['clone', encodeURI(url), folderPath], { cancellationToken });
rather than this proposed solution
await this.exec(parentPath, ['clone', url.includes(' ') ? encodeURI(url) : url, folderPath], { cancellationToken });
which specifically addresses spaces.

[scottymcraig]

Because encoding a string that already has encoding can cause it to be re-encoded. We just simply want to catch the cases where it comes from Azure DevOps with the spaces. None of the other cloning urls are having problems.

[PeterWone]

Yes and I've just checked, Azure DevOps won't allow any other toxic characters. Just being paranoid! :)

[MrJithil]

we don't really need to check whether the url contains a space. It will be more better, if we are encoding the url even if it is not contains a space.

[scottymcraig]

@MrJithil We can't do that - see my comment above Peter's

[Glober777]

Can't wait for this issue to be fixed :)

[joaomoreno]

Thought exactly the same as @PeterWone but I do like the reasoning from @scottymcraig.

Thanks for the fix!