Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: items in split view are not draggable without separator-border #59830

Closed
wants to merge 1 commit into from

Conversation

mdogadailo
Copy link

When you remove separator-border class from split-view, the split-view-view is no longer accept items to drag.

It can be reproduced when editorGroup.border has alpha 00.
2018-10-02_16-40-39

@joaomoreno
Copy link
Member

@bpasero AFAIK the editor grid implements DND without using the grid widget or spltiview at all. I believe you are the most qualified for a review of this PR.

@joaomoreno joaomoreno requested a review from bpasero October 3, 2018 10:17
@joaomoreno joaomoreno added this to the Backlog milestone Oct 3, 2018
@joaomoreno joaomoreno added the workbench-editor-grid Grid layout issues in the editor area label Oct 3, 2018
@bpasero bpasero modified the milestones: Backlog, October 2018 Oct 3, 2018
@bpasero bpasero self-assigned this Oct 3, 2018
@bpasero
Copy link
Member

bpasero commented Oct 3, 2018

@joaomoreno I confirmed this fixes the issue. However, this all seems to be due to the fact that .monaco-split-view2 > .split-view-container > .split-view-view does not set position: relative otherwise. I think the easier fix would be to put that property on independent from the border. I am positioning my DND drop widgets absolute within the grid and as such I need position: relative for this math to work.

@mdogadailo maybe you could simplify this change based on these findings?

@joaomoreno
Copy link
Member

@bpasero I moved position: relative to all split-view-view instances and everything is good, the change makes sense.

@mdogadailo Since I was already in the code, I'll just commit the changes directly. Sorry for that. Good investigation though.

@joaomoreno joaomoreno closed this Oct 4, 2018
joaomoreno added a commit that referenced this pull request Oct 4, 2018
@mdogadailo mdogadailo deleted the fix/separator-border branch October 4, 2018 08:37
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
workbench-editor-grid Grid layout issues in the editor area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants