Fixes for 58176: Middle clicking files in breadcrumbs explorer opens … #59797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as preview Added a variable to detect the middle click and pass the pinned option when this is true
|
This is a PR for the following issue: #58176. It's my first attempt and I would love to hear any feedback on if you felt there was a better way to implement this. |
jrieken
requested changes
Oct 3, 2018
| @@ -325,7 +325,7 @@ export class BreadcrumbsControl { | |||
| editorViewState = undefined; | |||
| } | |||
| this._contextViewService.hideContextView(this); | |||
| this._revealInEditor(event, data.target, this._getEditorGroup(data.payload && data.payload.originalEvent)); | |||
| this._revealInEditor(event, data.target, this._getEditorGroup(data.payload && data.payload.originalEvent), data.payload.originalEvent.middleButton); | |||
There was a problem hiding this comment.
data.payload might be undefined and will explode now
| @@ -408,11 +408,11 @@ export class BreadcrumbsControl { | |||
| this._ckBreadcrumbsActive.set(value); | |||
| } | |||
|
|
|||
| private _revealInEditor(event: IBreadcrumbsItemEvent, element: any, group: SIDE_GROUP_TYPE | ACTIVE_GROUP_TYPE): void { | |||
| private _revealInEditor(event: IBreadcrumbsItemEvent, element: any, group: SIDE_GROUP_TYPE | ACTIVE_GROUP_TYPE, middleClick: boolean = false): void { | |||
There was a problem hiding this comment.
I'd call it pinned instead of middleClick
|
Thanks for the feedback @jrieken. Let me know if these changes cover what you need. |
|
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…as preview
Added a variable to detect the middle click and pass the pinned option when this is true