Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loaded scripts view: use schedulers #57491

Merged
merged 1 commit into from
Aug 29, 2018
Merged

Conversation

isidorn
Copy link
Contributor

@isidorn isidorn commented Aug 29, 2018

fixes #57007

This PR does two things:

  • Introduces Schedulres in the LoadedScriptsView such that we no longer have to use timeouts. This should be cleaner and less error prone
  • Same as we have previously done for the new source, we now also refresh the tree with the timeout when a session gets ended (this fixes the issue attached)

I also believe this issue existed before the session refactoring.
One note for easier review: when the tree gets undefined as a refresh it will refresh the root, so we do not need to pass it.

@weinand Leaving up to you to review. Thanks!

@isidorn isidorn added this to the August 2018 milestone Aug 29, 2018
@weinand weinand merged commit e5cf46d into master Aug 29, 2018
@weinand
Copy link
Contributor

weinand commented Aug 29, 2018

thanks for the PR!

@isidorn
Copy link
Contributor Author

isidorn commented Aug 29, 2018

Welcome 😊

@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2020
@isidorn isidorn deleted the isidorn/loadedScriptSchedulers branch June 29, 2020 13:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot convert undefined or null to object
2 participants