Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefill quick open #55752

Merged
merged 2 commits into from
Oct 1, 2018
Merged

Prefill quick open #55752

merged 2 commits into from
Oct 1, 2018

Conversation

Michel73
Copy link
Contributor

@Michel73 Michel73 commented Aug 3, 2018

Implements #37932

@msftclas
Copy link

msftclas commented Aug 3, 2018 •
edited
Loading

CLA assistant check
All CLA requirements met.

@chrmarti chrmarti added this to the August 2018 milestone Aug 3, 2018
@chrmarti chrmarti modified the milestones: August 2018, September 2018 Aug 30, 2018
@Michel73
Copy link
Contributor Author

I moved all the logic according to the prefill-feature from quickOpenWidget to quickOpenController. Also the configuration aspects are handled in the quickOpenController without the need of disposing and recreating the QuickOpenWidget.
I also resolved the merge conflicts but github still asserts that they exists.

@Michel73
Copy link
Contributor Author

I had some problems synchronising with master repo. I had to rebase my branch. Now I did all the changes within a commit.

@chrmarti
Copy link
Collaborator

Just came back from vacation. I will take a look probably next week since we are working on stabilizing for the next release this week.

@chrmarti chrmarti modified the milestones: September 2018, October 2018 Sep 24, 2018
@utilityboy utilityboy mentioned this pull request Sep 24, 2018
Closed
@chrmarti chrmarti merged commit 9cd2bc0 into microsoft:master Oct 1, 2018
@chrmarti
Copy link
Collaborator

chrmarti commented Oct 1, 2018

Merged, thanks @Michel73!

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrmarti chrmarti chrmarti requested changes

@vikaskyadav vikaskyadav vikaskyadav approved these changes

Assignees

@chrmarti chrmarti

Labels
None yet
Projects
None yet
Milestone
October 2018
Development

Successfully merging this pull request may close these issues.
4 participants
@Michel73 @msftclas @chrmarti @vikaskyadav