Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround duplicate rendered characters in Electron 2.0.x #54474

Merged
merged 2 commits into from
Jul 20, 2018

Conversation

bpasero
Copy link
Member

@bpasero bpasero commented Jul 17, 2018

This is a PR for electron-2.0.x branch (not master) with an attempt to workaround #52196.

We suspect the issue lies within Skia and thus hope is little to get this backported to Electron. As a workaround, putting those span elements with opacity on a separate drawing layer seems to fix this issue. This impacts:

  • our unused variables style
  • decorations from extensions that leverage opacity

@bpasero bpasero added this to the July 2018 milestone Jul 17, 2018
@bpasero bpasero self-assigned this Jul 17, 2018
@bpasero bpasero requested a review from alexdima July 17, 2018 13:02
@Tyriar
Copy link
Member

Tyriar commented Jul 19, 2018

I think we should merge this and here's why:

  • It's temporary; we can revert it on the Electron 3 branch.

  • While new layers are created for elements containing will-change, this only happens for .squiggly-inline-unnecessary which are on unused variables (and decorations). In a typical project this should be fairly minimal.

  • It's far less risky that the alternative, the only "damage" it could do AFAIK is lower frame rate.

  • Even with a really bad case like the screenshot below (61 elements with .squiggly-inline-unnecessary) where the entire screen is filled with an unused variable, I can barely perceive a change in FPS.

    screen shot 2018-07-19 at 12 11 10 pm

@alexdima
Copy link
Member

👍 LGTM

@alexdima alexdima merged commit 2bb6021 into electron-2.0.x Jul 20, 2018
Copy link
Member

@alexdima alexdima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

@Tyriar Tyriar deleted the electron20x/editor-opacity branch July 20, 2018 15:44
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants